live commentslive comments
When you're viewing a thread and new comments show up, we now show indicators which you can click to reveal new comments. The goal is for threads to be a little more lively, higher velocity, like chat (without shifting the page around while reading). We plan on adding many more enhancements to this, but it should be useful already. (via @sox)
wallet v2 fixeswallet v2 fixes
- passphrase scanner bug
- wallet encryption key was sometimes stored ephemerally
- fixes to wallet logging
via @ek
wallet debug logswallet debug logs
wallets/debug- this mostly for interactive troubleshooting when folks are having issues with their wallets
via @ek
View all commits here: https://github.com/stackernews/stacker.news/commits/master/
Since starting the Open Source Contributor Award Rules (OSCARs), we've paid a total of 24.8m sats to 49 contributors for 253 contributions! View a nearly up to date list of contribution awards here: https://github.com/stackernews/stacker.news/blob/master/awards.csv
Previous release: #1041565
That’s going to make our discussion threads so much better!
Oh I didn't see you already made this comment
That’s quite ironic
lol right?
it did already!
Very cool!
immediately opens dev tools to see how it works
we be polling
You can go a long way with polling. Sure it’s not the most optimal, but often the other methods are very complicated and hard to get perfect.
Yeah, I'm a dev, I know that for a fact because I use it all the time 😄
I rarely go for a more complex solution like sockets or something else
Did you have to make any infra adjustments for the potential large increase in requests?
nope. we might have to add some new indices but the load should otherwise be pretty minimal at our scale.
This is going to be great for live game discussions in ~Stacker_Sports
@grayruby @Undisciplined
Live comments is really cool! I've many times had the experience of getting absorbed in writing a comment only to realize the conversation moved on while I was writing. Nice to get a sense of what's happening without needing to refresh the page.
Live comments is awesome!
I need to see this live comment item in action to understand it
reply to this comment and stay on the page. I'll reply to you and you can see it.
I saw it in action it’s really cool
I did say that the air felt live!
ok now let's all hope nothing breaks
cool. good job @sox and sn team!
the screenshot keeps making me think there are new comments
Just switch to light mode, then you won't mistake it for being a real comment thread
Woah:
Regarding wallet debug logs:
There's no link to the page anywhere in the UI on purpose since I want to link stackers to it on demand.
But if you're interested, here's one: /wallets/debug
@OT, @StillStackinAfterAllTheseYears, have your wallets been locked again since the last time? Can you reply with a screenshot of the page? (There's no sensitive information on it.)
If you want, you can also enable diagnostics, then I can see if there's anything interesting in the debug logs the next time it happens.
It hasn't happened for a while. Looks like it's working.
BUT
I might have found a new bug... When I want to paste a link into a post or comment the long press generates a Select All. After clicking Select All I'm then able to paste the link but it threw me off a few times.
Mhh, this sounds like an operating system thing
It’d be cool to have a live feature for posts on the ‘https://stacker.news/recent’ page. Is it easy to set up, @sox?
I don't necessarily think that it's difficult, I need to look into it ^^
@ek is this what you meant with
live posts?yes
it's live in here
going to keep this open just to feel alive
@WeAreAllSatoshi we have a fixed indicator for top level comments (I'm adding a top level for you to get a chance to see it ... maybe).
In general I think this will lead to a bunch of new enhancements around unseen comments. We already plan to change the favicon on new comments, and I want to have a fixed
nextbutton, kind of like how docusign does, for going to each new comment. I also don't want to have to click to reveal new comments (but we'll need to get clever with height calculations).✍️ fixed
nextbuttonyep, I was going to tag you! it'd be nice if that feature wasn't dependent on live comments and also worked for when we just revisit a thread that has new comments.
that's actually even cooler! I'm sure that
IntersectionObserverwill make this relatively trivial.Cool, I hadn't seen it yet, but now I did!
I'm excited to see the developments here.
It might be nice for a top-level, or fixed-with-scrolling indicator when new comments are available, as I may not be scrolled to the item sub-tree where new comments were added
Sorry @k00b, when you add a ln recieve wallet, does it confirm with an orange colour now, instead of green?
Or is that signifying a fault?
I'd only worry if it were red. The orange signifies warning. Meaning there's some recent wallet history suggesting the wallet didn't work as intended.
I had previously added minibits ln address and it said:
'failed to wrap invoice: Unable to estimate route, excessive values: {"routing_fee_msat":"0","time_lock_delay":"0","failure_reason":"FAILURE_REASON_NO_ROUTE"}'failed to wrap invoice: Unable to estimate route, excessive values: {"routing_fee_msat":"0","time_lock_delay":"0","failure_reason":"FAILURE_REASON_NO_ROUTE"}
I imagine that was the error
Yep, failed wraps will only cause warnings.
hey @Car
hey you were on snl right now where you at
yeah I know
still haven't seen it show me k00b
Being able to have multiple LN address wallets to receive is a great improvement, thank you.
What a dope move
These updates are solid The live comment indicator makes threads feel alive parang real time chat Wallet fixes and debug tools are super useful too. Great job sa lahat ng contributors sulit ang 24.8M sats
Nice.. Ure awesome
deleted by author
Yes, if you have enough CC, it will use CC.
You can also
disableyour coinos wallet temporarily.deleted by author