For those experiencing weirdness on deletion/selection with some Android keyboards, those should be (fingers crossed) fixed now. If you continue to have issues please report them!
There were also some more subtle bugs @sox interated on in this one.
for the nerdsfor the nerds
If @rblb's fix holds, the underlying cause is that composition events, which are non-keyboard text input events (like autocomplete/spelling fixes), were bugged in some Android keyboards and would race during deletion/selection.
The fix here was to suppress composition events during deletion/selection, preventing them from doing nutty things.
regardlessregardless
Given that we don't need a fancy editor for markdown, I suspect we may go back to using a textarea for markdown input so that there's always a first class (as a far as the browser is concerned) way to add content. But, even then, fixing these bugs is important to providing a WYSIWYG on Android.
Big thanks to @rblb who will be netting 3m sats for this fix, and @optimism (300k) for a thorough bug report.
The deletion error still persist for me (idk how?)
Also SN somehow adds "%E2%80%8B" behind several github url (what are these) even tho my link that i hid behind
[]()markdown didnt include those. Some examples from this postWhat i typed
https://stacker.news/items/1367331/editFlashSats redirect to this :
https://lsp.flashsats.xyz/api-docs/index.html%E2%80%8BAlso Swap Market
https://github.com/SwapMarket/swapmarket.github.io%E2%80%8BAlso PeerSwap
https://github.com/ElementsProject/peerswap%E2%80%8BAlso Thunderhub
https://github.com/apotdevin/thunderhub%E2%80%8BThe first Robosats url redirect to this
https://https//github.com/RoboSats/robosatsThe second Robosats url redirect to this
https://github.com/RoboSats/robosats%E2%80%8BAlso LNP2PBot
https://github.com/lnp2pBot/bot%E2%80%8BAlso Mostro
https://github.com/MostroP2P%E2%80%8BWhich deletion error? You try to delete and it doesn't let you?
That's weird. I'll create a GH issue. On the bright side, it's just a rendering artifact so it should go away once we fix it.
Fixed!
%E2%80%8Bis a zero width space (\u200b) that can be copied from somewhere else and pasted in our editor. It doesn't render on Apple WebKit, but it does on Chrom(ium) based browsers.Considering that we should allow this character to exist while editing (Lexical team might have their own motives), we strip it in
previewand after posting.Thanks again, here some sats <3
Yeah but after trying to type
[]()kind of text and whenever i make a mistake and try to delete a character somehow it didnt let me do it for a whileTry typing
[Stackerand deleting therletter somehow doesnt happenIn case this matter, i use Android 15 and i'm currently using Florisboard v0.5.2
Can you please tell me which phone make, model, and operating system you're using when this happens?
I use Redmagic 10 nx798j , Android 15 and my keyboard is Florisboard v0.5.2
Reproduced, thank you for reporting this!
I suspect we’re still going to fight some keyboards on Android, but I’m also happy that almost everything has been fixed.
Will work on it immediately.
cc @rblb
FlorisBoard uses a different way to delete, so it was not triggering the suppression. Patched: https://github.com/stackernews/stacker.news/pull/2719
I just woke up damn
Assuming im stupid (which i'm btw) is this exclusively Florisboard issue ? @sox @rblb @k00b thanks y'all for fixing this bug, sorry for bothering tho
No, it's an issue for several keyboards. I suspect they all use the composition logic from the opensource android keyboard, and so they've inherited all the same issues.
Florisboard just uses a non-standard way to delete content, so it wasn't covered by the first patch, but this is not a bug per se.
Happy to help 🫡
PSA: I'm hearing from @sox that I shipped this prematurely and there may be subtle issues.
We're reverting the fix for Android line break issues, because that's the reason that this wasn't ready for release. So Android folks should still see improvements but we'll need to spend a bit more time working on the line break weirdness.
Just noticed the editor acting up. First, pasting wasn't grabbing the whole clipboard—it kept cutting off at the linebreaks. Then it just glitched out like this, with the Markdown quote tags all broken. #1379760
Thanks! @sox is working on resolving the issues I presented by shipping this prematurely.
The thing causing those issues has been reverted in the meantime.
Just noticed #1379883 that after I dropped my text in the editor, the preview was messing up the line breaks. Once I picked the territory to post, it auto-edited my text and showed those breaks in the editor too. I just cleared 'em out and it’s all good now.
Great job. I was having a problem copy pasting nyms with other text but seems to be fixed now.
Thanks! @sox is working on resolving the issues I presented by shipping this prematurely.
I edited my comment. Issue seems to be fixed now. I should have checked before original comment.
Hey guys, thanks that's super generous!
Gracias @rblb de no ser posible estás acciones no hubiera podido disfrutar tanto de esta plataforma que me tiene enganchada más que la música y eso es mucho decir para mí 😅, mi teclado hasta ahora y el navegador está traduciendo bien después del arreglo estoy wuii 🤣⚡🧡