AI tools were not used in this code review. With 73,057 lines of diff output, I certainly am not going to claim I did a review sufficiently detailed to catch any malicious code changes from the point of view of a Knots user
neat, neat. but AI is red-teaming everything now?!
To summarize my findings, I do not believe that the BIP-110 implementation does anything particularly interesting from the point of view of someone running a non-BIP-110 node. Absent some kind of attack, given their current hash power they will most likely fork off into a separate coin with minority hash power (or even no hash power).
Say what you want about the fork, a real code review is the most adult thing in this whole circus. The signaling memes got 100x the attention of the actual diff and that's exactly backwards. Spec bugs are where forks die, not Twitter arguments. Even if BIP-110 is a band-aid, at least somebody checked it's clean before slapping it on.
neat, neat. but AI is red-teaming everything now?!
appreciate the write-up!
Ha!
When everyone else is using AI it's worth it if at least one guy does not.
How do you "code" without AI nowadays?
Surprisingly easily. Remove the "vibe" bit and just do the thing.
I like how calm you shared the review, without causing any heart attack:)
Imagine if the ones who actually know quietly audit the code, communicate, and fix everything in private, aren't this better for everyone?
There's a huge backlog of that. The AI teams (red, black, blue and transparent ones that you can't see) are attacking this backlog.
https://bip110monitor.com/
No off by one bug in this one? #2X
Ha!!!
Not that I know of. Though the potential of a new poison block attack that I mentioned would be interesting to look into further.
Thanks for this, Peter!
https://timechaincalendar.com/en
To summarize my findings, I do not believe that the BIP-110 implementation does anything particularly interesting from the point of view of someone running a non-BIP-110 node. Absent some kind of attack, given their current hash power they will most likely fork off into a separate coin with minority hash power (or even no hash power).
https://twiiit.com/peterktodd/status/2085849424501068056
Say what you want about the fork, a real code review is the most adult thing in this whole circus. The signaling memes got 100x the attention of the actual diff and that's exactly backwards. Spec bugs are where forks die, not Twitter arguments. Even if BIP-110 is a band-aid, at least somebody checked it's clean before slapping it on.