105 sats \ 4 replies \ @fanis 9 Jan 2023 \ on: Daily discussion thread
There was a post or comment not so long ago about proxying price API requests instead of having browsers directly getting the price from Coinbase, thus potentially leaking their IP to them. As I understand it'd take some work (probably needs caching on the proxy), wouldn't a good intermediate step be to have the option in the settings to totally disable any fiat-related stuff? Ticker would then always show "1 sat = 1 sat" when this option is enabled, and no request would be sent to Coinbase.
Yes I think it could be done.
I think it doesn't even need a setting.
It should only fetch the price if the user is currently looking at the price imo.
I think I can create a MR for that today, then @k00b can take a look at it.
reply
Well, with the ticker in the header users are kind of always "looking" at the price, aren't them? Or maybe deactivate getting the price if users set the "1 sat = 1 sat" view, if it's what you mean? But then it wouldn't be as straight forward to users that one of the differences is that they don't request data from Coinbase, while it could be made clear w/ a settings. Just my 2 sats :)
reply
Or maybe deactivate getting the price if users set the "1 sat = 1 sat" view, if it's what you mean?
Yeah, that's what I meant
But then it wouldn't be as straight forward to users that one of the differences is that they don't request data from Coinbase, while it could be made clear w/ a settings. Just my 2 sats :)
Good point, but I assumed people who care about stuff like this would notice without a setting since the price data must be coming from somewhere
But yeah, maybe the fiat currency dropdown can show a "disabled" entry.
edit:
Regarding
I assumed people who care about stuff like this would notice without a setting since the price data must be coming from somewhere
maybe I am biased here as a dev. Could be that people would care if they would know even though they don't know how to check for stuff like this. So it's not as simple as I described
reply
Could be that people would care if they would know even though they don't know how to check for stuff like this. So it's not as simple as I described
Exactly, I think there's a good crowd that cares but isn't even necessarily aware that an external API is being polled.
reply