What you're describing is more of an informal transaction than a charitable gift.

However, that doesn't mean it's not more effective than most charity. In general, imposing even minimal costs on receiving charity will have a dramatic effect on the incentives.

I don't think there's a particular right way to do charity, because everyone responds differently to different forms of help.