31 sats \ 5 replies \ @kristapsk 9 Mar 2023 \ on: My first bitcoin PR bitcoin
This was my first Bitcoin Core PR (was a result of me debugging my scripts that use bitcoin-cli). https://github.com/bitcoin/bitcoin/pull/13032
write
preview
0 sats \ 4 replies \ @ek OP 9 Mar 2023
I see you are a maintainer now. Nice! How long did it take?
(I assume you are a maintainer because you approved my PR)
reply
0 sats \ 3 replies \ @kristapsk 9 Mar 2023
No, I'm not a Bitcoin Core maintainer. Anybody can ACK or NACK commits in a PR after code review / testing (and the more people do this, the better). Maintainers are the only ones who can merge them at the end. But they are not supposed to use these rights if there are a lot of NACKs or not enough ACKs for more complex code changes.
https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md
reply
0 sats \ 2 replies \ @ek OP 9 Mar 2023
Yes, I know about the ACKs and NACKs. But I don't see an approve button. So I thought you have some special rights:
reply
21 sats \ 1 reply \ @kristapsk 9 Mar 2023
Ahh, no, that's just what GitHub writes if you select "Approve" instead of "Comment" at "Files changed > Review changes".
https://imgur.com/gGktFJ3.png
reply
0 sats \ 0 replies \ @ek OP 9 Mar 2023
Ah, I see haha
reply