How do devs decide who should have commit access? \ stacker news ~bitcoin

How do devs decide who should have commit access?bitcoin.stackexchange.com/a/99676

2330 sats \ 9 comments \ @ek 25 Apr 2023 bitcoin

view all related items

595 sats \ 8 replies \ @franzap 25 Apr 2023

Too many nodes run Bitcoin Core compared to other implementations, I think this is a weakness.

Would be nice to have a massive test suite that multiple implementations could run against.

63 sats \ 0 replies \ @ek OP 25 Apr 2023

Here it is: #86415

Parent for full discussion: #86303

0 sats \ 6 replies \ @ek OP 25 Apr 2023

There was a good discussion regarding this when the LND backend btcd had a consensus bug. Let me see if I can find it.

If I don't:

I think having one implementation is not a weakness but actually a strength. Making sure that all nodes run the same consensus rules is more important than to have multiple implementations imo.

10 sats \ 0 replies \ @ursuscamp 25 Apr 2023

I disagree. Many implementations with a good distributions is preferable. It helps decentralization (even harder to make consensus changes) and any bugs will become an implementation bug instead of de facto consensus change.

0 sats \ 4 replies \ @franzap 25 Apr 2023

Thanks. That's why I suggested a massive test suite such that consensus bugs would be caught (how often does consensus code change?)

There must be gotchas- I'm clearly not very familiar with the implementations and tradeoffs

20 sats \ 3 replies \ @benthecarman 25 Apr 2023

There is a massive test suite that has tests that cover btcd bug and btcd was using them. The problem was the bug was in the networking code not the consensus layer code.

It is extremely hard to have an exact copy of the rules, you have to remember that if there is a bug in bitcoin core, that bug is a consensus rule. Competiting implementations is just really not a good idea. Ethereum has many implementations and one of they have consensus problems all the time.

0 sats \ 1 reply \ @ek OP 25 Apr 2023

The problem was the bug was in the networking code not the consensus layer code.

Oh, didn't know that the taproot implementation is not part of the consensus layer.

Thanks for clarifying!

3 sats \ 0 replies \ @benthecarman 25 Apr 2023

It is a part of the consensus layer. The btcd bug happened because they were checking a segwit v0 rule against all txs at the network layer when they shouldn't have been

0 sats \ 0 replies \ @franzap 25 Apr 2023

Thanks!