They are both good.

Coldcard is more secure by virtue of the airgap (and some other features), but this makes it less convenient to use compared to the Bitbox.

If you have only a moderate stack and will be making transactions regularly, then perhaps Bitbox. For larger stacks which don't get touched often, perhaps Coldcard.

If in doubt, just get a Coldcard.