121 sats \ 4 replies \ @WeAreAllSatoshi 20 Aug 2023 \ on: Code review tool recommendations tech
I can’t help but feel responsible for this post lol
ETA: You should be able to add comments to the diff under the pending review, and you can choose to remove them before “releasing” the review to the developer.
lol you are. It looks really good by the way. Very tasteful and I'm really impressed with how well you navigated all the quirks of our codebase.
I do have enhancement suggestions though. Would you prefer I simply make the changes myself or would you like me to just suggest them? It's about the same amount of work for me either way, but in the latter case you potentially learn more about the codebase/patterns/deps (assuming my suggestions aren't full of crap ... which is plausible).
reply
Thank you, I appreciate the kind words!
Let's discuss the suggestions on the PR. That way they're documented for others to review later, more potential learning for me, etc.
reply
deleted by author
reply
deleted by author
reply