reply on: Code review tool recommendations \ stacker news ~tech

0 sats \ 10 replies \ @nemo 20 Aug 2023 \ parent \ on: Code review tool recommendations tech

deleted by author

0 sats \ 0 replies \ @_redacted 20 Aug 2023

Oh, that looks similar to git log --graph more

0 sats \ 8 replies \ @_redacted 20 Aug 2023

Are you looking at the history for your local history or do you pull down the PR ref and look through there?

0 sats \ 7 replies \ @nemo 20 Aug 2023

deleted by author

0 sats \ 6 replies \ @_redacted 20 Aug 2023

Are you collaborating on a branch/pr? All pushing to a mainline branch?

(asking as I normally do cicd automation and like knowing more about how folks work)

21 sats \ 2 replies \ @nemo 20 Aug 2023

deleted by author

0 sats \ 1 reply \ @_redacted 20 Aug 2023

Branch protection rules, yo!

Github has ... shitty automation around policies to enforce for an org. The rules are wonderfully powerful and while well documented for each option, don't give a good view on how to combine them for a nice safe way to work on code.

0 sats \ 0 replies \ @nemo 20 Aug 2023

deleted by author

0 sats \ 2 replies \ @nemo 20 Aug 2023

deleted by author

0 sats \ 1 reply \ @_redacted 20 Aug 2023

Humans are bad machines and the human should set the policy instead via automation.

Code formatters are a great case for just having a machine do it vs letting humans fight in PRs. Have a machine format code, make a status check to prevent bad cases getting through, then require the check to pass before merging.

Too much life has been wasted on debating code formatting in PRs.

0 sats \ 0 replies \ @nemo 20 Aug 2023

deleted by author