hold invoices for JIT

(via @ekzyis)
When I said JIT funding and anon payments were rough around the edges in the original release, what I meant was the unhappy path was rather kludgy. The payment settling and the action completing weren't atomic, so if you paid for an action then the action failed after payment (and you weren't satisfied/successful when retrying), we'd have to manually process a refund.
No more! JIT funding and anon payments now use short lived hold invoices so your payment is settled if and only if your action succeeds, ie it's refunded automatically if you choose to cancel it or retries don't succeed before it expires (and your work is still saved locally either way as always).

notification de-dupe

Before this change, if someone @'d you while also replying to you, you'd get two notifications, one for the reply and one for the mention. If you were also subscribed to the stacker (available in yesterday's release), you'd get a third notification. Now you only get one thanks to wearellsatoshi.
This is a "bug" I personally experienced way too much and am happy to be relieved of.

other stuff

There's a handful of other small stuff in this release but it's mostly small stuff.
The hold invoices is great. I wish I did that in the TBC backend, so many times the gift card providers would fail and we'd have the money and have to issue refunds
reply
I always forget about them. They’re so simple it’s easy to miss how useful they can be.
reply
I should've mentioned in the original release but @ekzyis came to the hold invoice conclusion completely on his own. It wasn't even on my radar.
He also seriously refactored this portion of the code to be way more reusable such that now most of the actions on the site that cost something can be done anon or with JITF.
reply
reply
deleted by author
reply
Oh thanks daddy
this is k00b ... sillyposting is how I sometimes entertain myself when testing locally
reply
I took your suggestion and subscribed to @anon. It’s like a feed for hot takes
reply
Exactly! I want to know where its going down. An anon had a screaming hot bolt12 take last week.
reply
deleted by author
reply
You get notified when anon's reply to you even without subscribing.
reply
deleted by author
reply
@anon hodls now
reply
Just for anyone who is confused by "JIT", it stands for "Just In Time" aka on demand, as needed.
reply
HODL invoices! Very cool 😎
reply
Small but significant change on the notifications - thank you.
reply
deleted by author
reply
Yep! @WeAreAllSatoshi is tearing through issues and @ekzyis was only half time before this week.
reply
deleted by author
reply
Oh is ekzyis full time now?
reply
3/4 time starting this week
reply
reply
deleted by author
reply
Thanks for all the great work you're doing!
reply