0 sats \ 6 replies \ @k00b OP 23 Oct 2023 \ parent \ on: SN release: gently personalized feeds, self-destructing items, text on links ... meta
Cache issue should be fixed
I’d just search for matchall somewhere
Mhh,
matchAll
is literally only used here but I think the default is not applied because we explicitly pass null
as the argument:lib/item.js:
export const getDeleteCommand = (text = '') => { const matches = [...text.matchAll(deletePattern)] const commands = matches?.map(match => ({ number: match[1], unit: match[2] })) return commands.length ? commands[commands.length - 1] : undefined } export const hasDeleteCommand = (text) => !!getDeleteCommand(text)
api/resolvers/item.js:
if (hasDeleteCommand(old.text)) { // delete any deletion jobs that were created from a prior version of the item await clearDeletionJobs(item, models) }
reply
reply
Thank you 🙏
reply
No worries :)
reply
Reinstalled PWA. Let's see
reply
We lost the required change in the serviceworker somehow. I probably did a bad rebase somewhere. New PR up.
reply