0 sats \ 8 replies \ @ek 25 Oct 2023 \ parent \ on: Bookmark settings bug meta
Was able to confirm this
Thanks for the report!
write
preview
0 sats \ 0 replies \ @Bitman OP 25 Oct 2023
Yay! Happy to have helped!
reply
0 sats \ 6 replies \ @WeAreAllSatoshi 25 Oct 2023
So basically the session needs updating on nym change?
reply
0 sats \ 5 replies \ @ek 25 Oct 2023
Yes. Or better: we should use user ids.
reply
100 sats \ 3 replies \ @WeAreAllSatoshi 25 Oct 2023
Yea, I didn’t want to refactor it to use IDs when I originally implemented the privacy feature, just to keep the changes smaller. But using IDs would have prevented this. However, it still surfaced a bug that needs fixing
reply
0 sats \ 2 replies \ @ek 25 Oct 2023
No worries, fix is simple :)
reply
21 sats \ 1 reply \ @WeAreAllSatoshi 25 Oct 2023
I still think we should update the session on nym change too, even though this change fixes the bookmark issue
reply
0 sats \ 0 replies \ @ek 25 Oct 2023
That would be ideal, yes
But I have the feeling it's not going to be simple. We would have to reissue a JWT which is handled by next-auth. Can we issue a new JWT without the need for reauthentication? Should we even be able to do that?
reply
21 sats \ 0 replies \ @WeAreAllSatoshi 25 Oct 2023
Good catch!
reply