If you never install pre-releases, it sounds to me like the documentation you reference indicates you don't need to worry about that flag. Or am I missing something?
This is correct. It's only needed if you're updating to a random commit that's not tagged as a release. Release candidates are tested for several weeks in advance to identify any bugs. So the database upgrade for a release is less risky and thus the database will update for a release regardless of the flag.
If you're installing the latest commit from master, there may be untested new features. Adding the database-upgrade=true flag means you're accepting the risk of a breaking change (you may have to wait for a fix, your node may be inoperable in the meantime.)
reply
That is my impression too. But I am a bit worried that not upgrading my database may become an issue for me a few releases down the line. I wonder whether this guy's problem is due to not upgrading their database.
reply
Yes, but my reading of the above is that the database does, indeed, get upgraded upon major release version anyway. I'm quite sure that's the case with my node, as I waited for the db migrations to finish for a min or two....
reply
Yes, this reassures me. Thanks for clarifying all that to me,
reply