pull down to refresh

For those interested, the code for the soft fork in bitcoin core was merged in this code change in 2016.
When github displays a code change it highlights any code that was removed in red and it highlights any code that was added in green. The code that was removed says this:
/** The maximum allowed size for a serialized block, in bytes (network rule) */ static const unsigned int MAX_BLOCK_SIZE = 1000000;
The code that was added says this:
/** The maximum allowed size for a serialized block, in bytes (only for buffer size limits) */ static const unsigned int MAX_BLOCK_SERIALIZED_SIZE = 4000000;
Notice that the block size used to be 1 megabyte but it changed to 4 megabytes. Segwit definitely included a block size increase.
Turns out, when we say 1MB in bitcoin, we really mean 1MB (not 1 MiB).
I always thought it's using powers of 2 even though it's using MB instead of MiB.
Interesting!
reply