Howdy there, partner! Welcome on into the Stacker Saloon.
Saddle on up to a stool and spill the beans about your day, fire away with them questions, or let loose and give us the lowdown on your wild and woolly life. We're all ears, so don't hold back!
We're open round the clock, so mosey on in whenever you please!
First time seeing this. Welcome!
Great! Good job. I think I got 3 of 'em last month and I suspect that they were all bots, but that "comes with the territory", in my case. lol
@optimism, I want to know what you think about this; my insecurity is holding me back:
I'm reviewing Add a "tx output spender" index.
I was confused by
-whitelist=noban@127.0.0.1in the tests. When I learned what it's for, I also learned aboutself.noban_tx_relay = True, which afaict does the same thing. I also noticed that tests usually useself.noban_tx_relayinstead of a manual-whitelist. I now consider mentioning this as a nit in my review when I'm done.But I'm not sure, because it's a nit. In the grand scheme of things, it doesn't matter. Also, the other reviews are about more important things. Nobody else mentioned it. Isn't this nit just distracting, then? Wouldn't it just look like I'm showing off that I know about
self.noban_tx_relay? lolI might only mention it when I also have something more important to mention.
Anyway, I guess my question is: Would you mention this as a nit? Or is this too much of a nit even for a nit?
I'm glad you're here so I can ask you this, but I’m sad I need to ask someone this instead of just making a decision on my own
Nit:(haha) I think a better person to talk to this about is @sedited as an actual project maintainer - I have zero commits to Bitcoin Core and I intend to keep it that way. There are things I want to remain an independent user of!Personally, (on any other repo, haha) I'd do this:
nit:, so that it is clear that it's not a showstopper finding.Per my above rationale, it absolutely does matter. It helps when reviewing now to see the nit, rather than having to context switch into that code later once more and think about it again. Human minds (at least of code reviewers) aren't that different from LLMs in terms of context resets!
Just mention it, don't make a show out of it. Stay humble and spend effort.
Aww.. I'm glad you're here too
<3especially on Bitcoin Core where every little nit is not just technical debt, but social debt because it is another PR that needs to be reviewed by 10s of people. Catch 'em while they're hot! ↩
87th Cowboy Plunda Drop in the @saloon
Howdy cowboy! Come on in!
Use that fancy LN wallet you got and login into plunda.co and git you some loot! Get a shot at some coins🪙 Box of loot🎁 or an arcade token!
Use the below voucher code to collect!
GDKSLEF9RR1MTo redeem Click here
Got questions? Reach out to the sheriff @plunda
Coin of the day:
I'm glad @k00b took my suggestion to sync the daily subsidy with the block mining reward!
No wonder you are a statist. You love to be paid by gov.
I'm not gonna talk about that again!
hahahahaha
Is not the SN pool rewards like a communist state subsidy ?
I was for long time a supporter of removing any of these "subsidies", remember? #796213
CAmount GetBlockSubsidy(int nHeight, const Consensus::Params& consensusParams) { int halvings = nHeight / consensusParams.nSubsidyHalvingInterval; // Force block reward to zero when right shift is undefined. if (halvings >= 64) return 0; CAmount nSubsidy = 50 * COIN; // Subsidy is cut in half every 210,000 blocks which will occur approximately every 4 years. nSubsidy >>= halvings; return nSubsidy; }https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp
I am talking about SN rewards pool. The Bitcoin mining "subsidy" is totally something else.
If thoughts create reality, then whoever controls thoughts controls reality. Edward Bernays wrote that “The conscious and intelligent manipulation of the organized habits and opinions of the masses is an important element in democratic society. Those who manipulate this unseen mechanism of society constitute an invisible government which is the true ruling power of our country.” If you control the narrative, you control collective belief, which shapes the collective behavior, and manifests material reality. The material reality then reflects back and proves that the narrative was true, which reinforces the loop. The battle for your mind is a battle for reality itself.
The Conversation. A short 12 min movie.
And one of important key in this manipulation today are the so called "prediction markets". Really powerful to manipulate the consciousness of clueless people and what is even more evil is that people participate in this way into their own manipulation.
And they just laugh how stupid are clueless people...