TLDR; You can keep channels open indefinitely. There are 6 special situations when you want to close a channel listed below:

1. You want sats on-chain
2. Your peer is offline for too long
3. Hardware is struggling with too many channels
4. You're moving to a new node
5. You'are going offline for a long time
6. You're profit oriented and the channel is not profitable or very profitable