pull down to refresh
0 sats \ 6 replies \ @k00b OP 18 Feb 2023 \ parent \ on: SN bounty: display image when provided an image link meta
If someone else has implemented it and I've accepted it, this bounty on SN will show as paid.
If someone has implemented it, they'll likely have submitted a PR.
ok, well I'll give it a go and hope nobody else is hacking away at it, otherwise my time will be wasted. still, will be a good to learn a bit about the SN codebase
reply
I didn't start working on this to give new contributors a chance :)
(I have been contributing to the SN codebase for some time now and I also claimed the previous bounty.)
Looking at the comments and Github, I think no one else has picked this up so I think you have good chances to get the bounty.
I am also glad to see someone picking this up!
reply
Created a new Github issue for collating any feedback: https://github.com/stackernews/stacker.news/issues/239
reply
thanks for the comment, spent some time tidying up and ended up also implementing the async lookup for when regex won't work.
i'll do a write-up in the morning and share it to get some feedback. once I started digging into this feature I found lots of little edge cases and considered several ways of implementing it, so i'll be curious what you think of the code
reply
There will be more bounties and if someone beats you to it yet your work is solid, I'll give you a partial bounty for the effort.
reply
I've got the first slice of this feature coded up, just needs a bit of tidying.
I figured that it'd makes sense to break the work down into two parts:
- Done: synchronously regex check and format urls that have a recognisable image url format
- TBD: asynchronously check urls and format them as images if the mimetype returned is an image
i'll open up a pull request to get some initial feedback and if you'd prefer not to merge until both parts are completes, that's your prerogative
reply