pull down to refresh
273 sats \ 6 replies \ @k00b 25 Aug 2023 \ on: Daily discussion thread
Observation: it's harder to pinch off a release when working with multiple people.
We have 14 commits of varying size waiting for deployment but I find myself always want to merge "one more pr" or add "one more thing."
Let me know if there’s something I can do as a contributor to help this process.
One idea could be to group all the small PRs together and release those relatively quickly, then go in and do the meatier ones over longer time periods to give you more confidence
reply
Thanks! I definitely need a process.
I think once we get some tests on the wallet stuff, no release should require much time to be confident in.
reply
I was noodling around writing tests for some of the sql functions today but didn’t come up with any great ideas that didn’t require spinning up the DB and executing against it. That would make the test suite heavier to execute than preferred, IMO.
Maybe it’s not the worst thing, though. Seed some users. Write test cases that create items, zap, and verify expected wallet states.
reply
I think you're right. There's no alternative to an integration/e2e style test.
reply
deleted by author
reply
That's a good point. One reason I find myself piling in PRs to a release is so I can test everything together ... I think I'm saving time, but I'm probably just slowing the release cycle down.
reply