pull down to refresh

99 sats \ 10 replies \ @k00b 12 Oct 2023 \ parent \ on: Stacker Saloon

yeah afaict every change is causing a rerender ... "hook 10 & 11 changed" ... I wish the profiler could name the dang things

write
preview
10 sats \ 9 replies \ @WeAreAllSatoshi 12 Oct 2023

This this? https://i.postimg.cc/7LzfwT3v/image.png

Always parse hook names from source

reply
0 sats \ 7 replies \ @k00b 12 Oct 2023

Sweet!

reply
21 sats \ 6 replies \ @WeAreAllSatoshi 12 Oct 2023

I'm not sure I've pinpointed the exact issue, but making more use of useCallback and useMemo in the MarkdownInput and UserSuggest components seems to be helping locally. At least, I see fewer longer commits in the profiler

reply
21 sats \ 4 replies \ @k00b 12 Oct 2023

I suspect if might be enough to not setUserDropdownStyle and setMentionIndices on every change. These object literals each have a new reference and trigger a rerender even if the object is functionally identical.

reply
100 sats \ 2 replies \ @WeAreAllSatoshi 12 Oct 2023

I assume you have this change worked up locally? I won't work up a PR. LMK otherwise.

reply
21 sats \ 1 reply \ @k00b 12 Oct 2023

Yep thanks

reply
31 sats \ 0 replies \ @nemo 12 Oct 2023

deleted by author

100 sats \ 0 replies \ @WeAreAllSatoshi 12 Oct 2023

Yes, I think so, too. Those could only be set when there is a @ mention query found, not just every change. We only need them to be accurate in that case.

reply
30 sats \ 0 replies \ @nemo 12 Oct 2023

deleted by author

0 sats \ 0 replies \ @WeAreAllSatoshi 12 Oct 2023

Try this*

reply