@ek has overhauled wallets with some of the things we've learned over the last 6 months or so:
- attach wallets, not protocols
- attach multiple versions of the same wallet and protocol
- implicit send wallet device sync
- device sync is on by default and you only need to bother with copying passphrases when adding additional devices
- improved logging
The UI/UX is admittedly a little rough around the edges still, but the foundation, the hard part, is better suited to our plans and needs. We'll iterate on UI/UX based on feedback and please let us know if you experience any problems.
if you are being asked for your passphrase unexpectedlyif you are being asked for your passphrase unexpectedly
You will need to click reset, creating a new passphrase, and attach your sending wallets again.
Our on-device migration to 'wallets v2' failed for some of you. There was a bug that re-encrypted your wallets with a new passphrase which will make your existing attached sending wallets inaccessible. We're so sorry and know how frustrating this stuff is.
I'll be online all day to help with any problems. Please mention me or ek if you need help.
View all commits here: https://github.com/stackernews/stacker.news/commits/master/
Since starting the Open Source Contributor Award Rules (OSCARs), we've paid a total of 24.8m sats to 49 contributors for 253 contributions! View a nearly up to date list of contribution awards here: https://github.com/stackernews/stacker.news/blob/master/awards.csv
Previous release: #1010425
Now I am getting this message on mobile when attempting to access my wallets:
failed to load walletsdecryption error@ek
@k00b
Thank you, so decryption is indeed failing.
But you can load your wallets fine on desktop?
Yes. everything is fine on desktop.
You're using grapheneOS on mobile right siggy? I wonder if the browser doesn't support a feature we expect or something.
Correct
Hey, sorry we still haven't figured out what's going wrong on your mobile device. We just pushed some more code. Do you now see
decryption error: OperationError?Actually, the button "unlock wallets" has reappeared, under which "password is required" appears. So, when I unlock, they ask for the passphrase. I then copy it from my laptop and paste it into my phone. It then says it is the wrong pass phrase. Scanning the qr code also fails. What I plan to do now is reset the wallet on my laptop, then attempt to create a fresh nwc send link on my phone, and then try to link my laptop with the passphrase. I use SN more on the phone than the laptop.
Never mind. The pass phrase now works, and everything seems good to go. !!!!! Yep, I'm zapping away.
wooo, let's go!
sorry for the bad experience though
At this point, if not too inconvenient, you could also try to clear your browser storage to remove the key that is trying to decrypt your wallets.
You should then definitely get the button to enter your passphrase.
ohhh, this is a good hint
Can you give me a screenshot of the wallets page on desktop so I can check if what you see is also what I expect you to see?
deleted by author
Okay, that's what I expected, mhh.
You can delete the screenshot now if you want
deleted by author
Do we still clear storage on logout? That might be a quick fix if so.
No, because there's nothing to clear anymore
edit: oh, except the key ...
Great job!
When you open any page on SN for the first time, that orange square pops up next to the nym. It disappears really fast though, I don’t think it used to do that. browser version.
damn, that's a regression, thanks for the report
Also, I noticed a brief 500 when loading SN earlier this morning. I assume it was during this deployment?
Yep, we expected a backwards incompatible rolling deployment (db gets migrated, but client doesn't know yet), but this migration was also non-atomic (spread across two migrations) and the second one failed unexpectedly requiring manual intervention.
I woke up at 5a this morning and ek and I were in a video call anticipating something like this. By far, this is the most complicated migration we've done to date. We migrated 'polymorphic' relations (ie a hack with triggers for fast polymorphic joins) and encrypted columns, nearly doubling the number of tables we store wallet related stuff in.
5am...migrated polymorphic relations...backwards incompatible rolling deployment...failed unexpectedly
this is what I imagine my nightmares would be like if I was a developer.
This was a nightmare. When these migrations fail, you have no idea how long it might take to resolve. Even with tons of QA, we experienced a bunch of problems.
Modeling data for long term storage and millisecond access is hard. Getting the design wrong, like we did with wallets v1, is very expensive.
actually awesome omg
ah that's what that was
yes
Okay I am back in action! Should I establish a passphrase now?
I'd wait to establish the passphrase until you need to sync with a device and can write it down.
Okay thank you.
Nvm I see the app already set one for me after I reset
Yes, it gives you a one immediately so that your wallets are properly secured even without syncing to other devices yet.
Sigh! I wish we had more warning this was going to come. I am not going to be able to resync my wallets till this evening. Thus I may have trouble zapping all day.
Stuff like this is exactly why I’ve been keeping a buffer (~5k) of sats and CCs in my SN wallet. That way I 'never' run into issues! If you need some CCs, just say it, I’ll lend you some!
they need to include credit card purchase of Cowboy Credits will be easier process than focusing for an exchange for BTC LN elsewhere, especially for dummy people how first signup on stacker news
Nah, that ain't really a priority right now. We gotta grow way more before we even need that feature.
Thanks. I do have a workaround but it’s just a real pain in rear to do. But let me get working on it
I'd be happy to buy you some cowboy credits for your trouble and to keep the zaps coming.
Thanks but I have a workaround that I do in situations like this. It’s annoying but I can get back up and zapping in a bit.
Thanks for the offer
This is a great offer, no jk.
Okay, I created a new send passphrase on dektop linux, and things seem fine. On mobile, I can't access wallet, nor can I zap. It just keeps reloading.
mhhh, not sure yet why it would load forever
will keep you updated
Okay. Can you explain how to unsync devices now? Maybe I can unsync, load a new passphrase on mobile, then live with them unsynced for a while?
ek removed the ability to unsync.
I'm sorry siggy. I'm confident you'll need to reset and reattach sending wallets.
That's okay, but I can't reset on mobile. It keeps reloading. The send ability I have on desktop is not synced with mobile, so I can't zap on my phone. Timing sucks, since I'm going away tomorrow and won't have access to my desktop, lan for nodes, etc. Oh well. I guess I'll be cc'ing for a while.
I should have added code to show errors to users. I think loading your wallets is failing.
Will do that now, we should definitely be able to get your wallets to load on mobile within the next few hours
Great. Either way I'll figure something out.
There's no unsync anymore, all sending wallets are now always stored encrypted on the server.
The first device you opened SN with today gets to set the key, and when you use a different device, it will either already have the same key, or it won't, then it will ask you for the passphrase to derive the same key.
But I think something went wrong with detecting existing keys, so we accidentally generated new keys for some 🙈
But not sure if your wallets loading forever on mobile is related to that.
I was weary of that new vibe coded hook that you made last minute. Is that the cause?
The bug is at least happening in there, but it might also have happened with what I had before
it wasn't vibe coded though 👀
lol
it just looked pretty thoroughly cooked, like most vibe code things
Found a bug that is related to why old passphrases no longer work, but not sure I can fix it in a way that they will start working again, only that it doesn't happen again.
If you want to submit a pr, I can try to get it deployed before some folks encounter the bug.
okay, should be up in 10 minutes
edit: nooo, can't reproduce anymore
deleted by author
Wow, great work. I didn’t realize there were so many wallet choices!
It's even only the ones that stackers already attached in some way via the existing options.
There are probably a lot more!
We have plans to leverage that page of all lightning wallets on this planet
things seemed pretty smooth for me via lnd attachment option. no apparent interruption except for a few moments where i got a 500 internal server error.
thanks for the feedback, glad it worked for you
thanks for your work. logs and wallet pages are looking pretty slick.
Congrats on the release!
I know I wasn't thrilled with non-custodial move when it was announced and first implemented but I think I've seen the light on connected wallets.
It seems like SN is out in-front of the pack of experimenting and implementing this concept, which also happens to be gaining regulatory legitimacy at the same time.
Congrats on the release! I can vouch all these wallet integrations take a lot of hard work to accomplish...and even more "sweat and tears" to work seamlessly!
lookin damn good!
I saw this message , just clicked reset and attached coinos wallet. All working smoothly. Thanks for this upgrade!
thanks for the feedback!
Thank you SN Team for the nice job. SN is self-custodial
I didn't get any notifications or messages to do anything. Does that mean no action is needed on my part? I seem to be able to zap from my wallet (Alby Desktop connected via NWC)
Yes, don’t need to do anything, that’s how it was supposed to go
I’m guessing the gun requirements were lightened up? I’m a triple threat again!
Device sync is on by default now.
Adding my ln recieve and nwc send, I noticed the new layout, nice layout and good ux, cashu me is available which is pretty cool. Nice touch
thanks and welcome!
Yall just keep on pumping out the improvements!!! Thank you!
And there you go, you’re all set!
Easier process may be
Hi 👋, thanks for always trying to improve SN, I'm new. Should I fix anything?
deleted by author
Does BitKit support NWC, provide a lightning address or any other API to send or receive?
just LN address that I know, maybe some sort of APIs to send/receive but not sure
I just downloaded BitKit and I can't find a lightning address
need to add an LSP or open a channel with wallet funds
urgh