Review Payjoin PSBT Validation PR (35 Lines of Rust)
580 sats \ 8 comments \ @bitgould 3 Feb 2023 bitcoin
I'm looking for help getting better privacy and transaction batching into your wallet. It won't be easy but everyone using bitcoin will benefit.
Please review the design and correctness of these 2 psbt validation checks (is_finalized? utxo info is filed in?) and weight computation in this payjoin pull request in sender/mod.rs.
The sender validates the payjoin proposal psbt according to the BIP 78 spec. The PR outlines the exact relevant specification.
There will be more opportunities for review as the payjoin library comes out of alpha and more users demand the benefits of bitcoin privacy.
Happy to answer questions and looking forward to innovating together.
This bounty expires one week from today.
101,000 sats paid
write
preview
bitgould's bounties
102.3k sats \ 1 reply \ @benthecarman 3 Feb 2023
Left some review
reply
0 sats \ 0 replies \ @bitgould OP 4 Feb 2023
that was quick
reply
12 sats \ 3 replies \ @bitgould OP 3 Feb 2023
I realize now that the sats I get for this post subsidize the bounty, too. Thank you stackers. You're making bitcoin better ❤️
It's also a little weird to me that paid bounties are green. Shouldn't the colorful, "LOOK HERE" detail be for those that are still available for a limited time @k00b?
reply
6 sats \ 2 replies \ @k00b 3 Feb 2023
I see what you mean. It's meant to be grey is unpaid (boooo), paid is green (yayyy), but to your point it might be better as unpaid green (yay sats await), paid grey (boo sats spent).
Representing state in a single icon is tricky. Should the representation be its current state or its potential state? e.g. if I'm in light mode, should the icon to switch to dark mode by a sun or a moon?
Most UX people seem to believe it's the current state. I tend to like potential state which kind of speaks to your preference.
The motivation for the way we did it was being able to tell at a glance, when looking at a list of a user's bounties, if they pay their bounties or not.
reply
0 sats \ 1 reply \ @bitgould OP 3 Feb 2023
No question there is a method to your madness. Stacker news has pull.
In color to me implied "BAG IS HERE" current state vs bag is gone. It's all still so new 🤷🏻‍♂️
reply
0 sats \ 0 replies \ @k00b 3 Feb 2023
Honestly it probably just needs a label. It can be debated either way.
The clearest dark mode/light mode switchers have an icon for all options and the current state is highlighted (e.g. https://gwern.net/). Explicitness is simplest.
reply
138 sats \ 0 replies \ @siggy47 3 Feb 2023
Way above my skill level, but I applaud you using SN member resources in this way!
reply
2 sats \ 0 replies \ @nabingyawali0 3 Feb 2023 freebie
Stacker news is perfect. Just loved. Keep moving
reply